Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8350480: RISC-V: Relax assertion about registers in C2_MacroAssembler::minmax_fp #23723

Closed
wants to merge 1 commit into from

Conversation

RealFYang
Copy link
Member

@RealFYang RealFYang commented Feb 21, 2025

Hi, please review this trivial change.
The current assertion about the registers is more than needed.
It requires that dst, src1 and src2 must be different from each other.
But the code only required that dst must be different from src1 and src2.
Patch simply relaxes the assersion removing the unneeded constraint.
fastdebug builds OK with change.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8350480: RISC-V: Relax assertion about registers in C2_MacroAssembler::minmax_fp (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23723/head:pull/23723
$ git checkout pull/23723

Update a local copy of the PR:
$ git checkout pull/23723
$ git pull https://git.openjdk.org/jdk.git pull/23723/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23723

View PR using the GUI difftool:
$ git pr show -t 23723

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23723.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2025

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 21, 2025

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350480: RISC-V: Relax assertion about registers in C2_MacroAssembler::minmax_fp

Reviewed-by: mli, fjiang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • dfcd0df: 8350019: HttpClient: DelegatingExecutor should resort to the fallback executor only on RejectedExecutionException
  • 1b6281d: 8321003: RISC-V: C2 MulReductionVI
  • c73fead: 8350383: Test: add more test case for string compare (UL case)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Feb 21, 2025

@RealFYang The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@RealFYang RealFYang marked this pull request as ready for review February 21, 2025 06:39
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 21, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2025

Webrevs

Copy link

@Hamlin-Li Hamlin-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 21, 2025
Copy link
Member

@feilongjiang feilongjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RealFYang
Copy link
Member Author

@Hamlin-Li @feilongjiang : Thanks!
/integrate

@openjdk
Copy link

openjdk bot commented Feb 22, 2025

Going to push as commit a891630.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 5cbd9d1: 8349959: Test CR6740048.java passes unexpectedly missing CR6740048.xsd
  • 25322aa: 8350258: AArch64: Client build fails after JDK-8347917
  • 825ab20: 8350456: Test javax/crypto/CryptoPermissions/InconsistentEntries.java crashed: EXCEPTION_ACCESS_VIOLATION
  • 9d9d7a1: 8349759: Add unit test for CertificateBuilder and SimpleOCSPServer test utilities
  • b45c32c: 8350287: Cleanup SA's support for CodeBlob subclasses
  • bd8ad30: 8350285: Shenandoah: Regression caused by ShenandoahLock under extreme contention
  • 24b5573: 8350444: Check for verifer error in StackMapReader::check_offset()
  • dfcd0df: 8350019: HttpClient: DelegatingExecutor should resort to the fallback executor only on RejectedExecutionException
  • 1b6281d: 8321003: RISC-V: C2 MulReductionVI
  • c73fead: 8350383: Test: add more test case for string compare (UL case)

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 22, 2025
@openjdk openjdk bot closed this Feb 22, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 22, 2025
@openjdk
Copy link

openjdk bot commented Feb 22, 2025

@RealFYang Pushed as commit a891630.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants