8371721: Refactor checkTrusted methods in X509TrustManagerImpl #28275
+81
−114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 3 checkTrusted methods in X509TrustManagerImpl have a lot of repeating code that can be moved into a helper method.
Also refactoring X509TrustManagerImpl logging code since we are touching this file.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28275/head:pull/28275$ git checkout pull/28275Update a local copy of the PR:
$ git checkout pull/28275$ git pull https://git.openjdk.org/jdk.git pull/28275/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28275View PR using the GUI difftool:
$ git pr show -t 28275Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28275.diff
Using Webrev
Link to Webrev Comment