8371480: VerifyError after JDK-8369654

[vicente-romero-oracle]

It seems like the fix for JDK-8369654 went too far simplifying the new algo equivalent to the more complex idiom: erasure(lub(t))
As defined in the mentioned fix, it could happen that the list of erased supertypes lists interfaces first followed by classes. Getting the first element in this list would yield an interface which won't then be equivalent to the idiom it is replacing. The current fix adds another operation that should minimize the list of supertypes and sort them classes first and then interfaces.

TIA

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371480: VerifyError after JDK-8369654 (Bug - P2)

Reviewers

• Maurizio Cimadamore (@mcimadamore - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28276/head:pull/28276
$ git checkout pull/28276

Update a local copy of the PR:
$ git checkout pull/28276
$ git pull https://git.openjdk.org/jdk.git pull/28276/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28276

View PR using the GUI difftool:
$ git pr show -t 28276

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28276.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371480: VerifyError after JDK-8369654

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 7d78818: 8274178: G1: Occupancy value in IHOP logging and JFR event is inaccurate
• bbc0f9e: 8371788: Fix documentation for CollectedHeap::collect(GCCause)
• 6b6fdf1: 8357874: UNLIMTED_CRYPTO typo in class description of JceSecurity.java.template
• ... and 15 more: https://git.openjdk.org/jdk/compare/e5c72937af50433029b8d4b6b30a5318c31a9da4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@vicente-romero-oracle The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0798d7b6)

[mcimadamore]

Looks good!

[vicente-romero-oracle]

Looks good!

thanks for the review!

/integrate

[openjdk]

Going to push as commit 8102f43.
Since your change was applied there have been 18 commits pushed to the master branch:

• 7d78818: 8274178: G1: Occupancy value in IHOP logging and JFR event is inaccurate
• bbc0f9e: 8371788: Fix documentation for CollectedHeap::collect(GCCause)
• 6b6fdf1: 8357874: UNLIMTED_CRYPTO typo in class description of JceSecurity.java.template
• ... and 15 more: https://git.openjdk.org/jdk/compare/e5c72937af50433029b8d4b6b30a5318c31a9da4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vicente-romero-oracle Pushed as commit 8102f43.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.