8371682: Suppress javac warning from ThreadPoolExecutorSubclassTest.java

[sendaoYan]

Hi all,

In JDK 11, ThreadPoolExecutor.finalize() was specified to do nothing, leaving the finalize() method empty by JDK-8371748, so I think it's safety to remove finalize() in testFinalizeMethodCallsSuperFinalize for test/jdk/java/util/concurrent/tck/ThreadPoolExecutorSubclassTest.java.

This PR also remove unnecessary '@SuppressWarnings("removal")' in test/jdk/java/util/concurrent/tck/JSR166TestCase.java and test/jdk/java/util/concurrent/tck/ExecutorsTest.java.

Change has been verified locally on linux-x64 by run test java/util/concurrent/tck/JSR166TestCase.java#default. Test-fix only, no risk,

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371682: Suppress javac warning from ThreadPoolExecutorSubclassTest.java (Bug - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28278/head:pull/28278
$ git checkout pull/28278

Update a local copy of the PR:
$ git checkout pull/28278
$ git pull https://git.openjdk.org/jdk.git pull/28278/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28278

View PR using the GUI difftool:
$ git pr show -t 28278

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28278.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (374c8ef8)

[AlanBateman]

I think the changes in this PR are okay. I think it is time to remove TPE.finalize too (not this PR of course).

[SirYwell]

What does testFinalizeMethodCallsSuperFinalize test now?

[sendaoYan]

What does testFinalizeMethodCallsSuperFinalize test now?

I have verified java/util/concurrent/tck/JSR166TestCase.java#default locally, test still run passed. Test java/util/concurrent/tck/JSR166TestCase.java#default will invoke all the junit tests in java/util/concurrent/tck directory.