8371419: IGV: Add view to visualise dominator tree and dominator information #28293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a dominator tree view in IGV’s CFG panel, enabling users to toggle between the control flow graph and the dominator tree. This makes dominator relationships easier to inspect than the current stdout-based output (
-XX:+PrintDominators).Motivation
-XX:+PrintDominators, which is hard to read and correlate with the graph).What’s New
idom: immediate dominatordom_depth: dominator depthblock: numeric block ID for all nodes in a blockThe resulting main view looks like this:

Testing
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28293/head:pull/28293$ git checkout pull/28293Update a local copy of the PR:
$ git checkout pull/28293$ git pull https://git.openjdk.org/jdk.git pull/28293/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28293View PR using the GUI difftool:
$ git pr show -t 28293Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28293.diff
Using Webrev
Link to Webrev Comment