Skip to content

8380441: G1: Move G1GCPauseType to G1CollectorState#30330

Open
tschatzl wants to merge 2 commits intoopenjdk:pr/30233from
tschatzl:submit/8380441-g1pausetype-to-collectorstate
Open

8380441: G1: Move G1GCPauseType to G1CollectorState#30330
tschatzl wants to merge 2 commits intoopenjdk:pr/30233from
tschatzl:submit/8380441-g1pausetype-to-collectorstate

Conversation

@tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Mar 20, 2026

Hi all,

please review this change that moves G1GCPauseType into G1CollectorState.

This improves readability imo as it reduces the scope of that type and puts it together with its source.

Based on #30233, so please review that one first.

Testing: gha

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #30233 must be integrated first

Issue

  • JDK-8380441: G1: Move G1GCPauseType to G1CollectorState (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30330/head:pull/30330
$ git checkout pull/30330

Update a local copy of the PR:
$ git checkout pull/30330
$ git pull https://git.openjdk.org/jdk.git pull/30330/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30330

View PR using the GUI difftool:
$ git pr show -t 30330

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30330.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 20, 2026

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into pr/30233 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 20, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Mar 20, 2026
@openjdk
Copy link

openjdk bot commented Mar 20, 2026

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@tschatzl tschatzl changed the title * initial version 8380441 Mar 20, 2026
@openjdk openjdk bot changed the title 8380441 8380441: G1: Move G1GCPauseType to G1CollectorState Mar 20, 2026
@tschatzl tschatzl marked this pull request as ready for review March 20, 2026 12:02
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 20, 2026
@mlbridge
Copy link

mlbridge bot commented Mar 20, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant