8380532: Parallel: Rename allocate to cas_allocate in PSYoungGen

[albertnetymk]

Trivial renaming an API of PSYoungGen.

Test: tier1

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8380532: Parallel: Rename allocate to cas_allocate in PSYoungGen (Enhancement - P4)

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Joel Sikström (@jsikstro - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30333/head:pull/30333
$ git checkout pull/30333

Update a local copy of the PR:
$ git checkout pull/30333
$ git pull https://git.openjdk.org/jdk.git pull/30333/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30333

View PR using the GUI difftool:
$ git pr show -t 30333

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30333.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8380532: Parallel: Rename allocate to cas_allocate in PSYoungGen

Reviewed-by: tschatzl, jsikstro

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• b32e9b0: 8378806: Genshen: Add scope of collection to end of cycle message in JMX notification
• 396cc0a: 8380534: Use loopback address in java/net/DatagramPacket/ReuseBuf.java test
• f7c427f: 8379182: [test] java/lang/ProcessBuilder/PipelineLeaksFD.java fails

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d697b48c)

[jsikstro]

Looks good.

Do we also want to follow this up to rename the allocate method in PSOldGen to cas_allocate?

  // Used by GC-workers during GC or for CDS at startup.
  HeapWord* allocate(size_t word_size) {
    HeapWord* res;
    do {
      res = cas_allocate_noexpand(word_size);
      // Retry failed allocation if expand succeeds.
    } while ((res == nullptr) && expand_for_allocate(word_size));
    return res;
  }

  // Invoked by mutators before attempting GC.
  HeapWord* cas_allocate_noexpand(size_t word_size) {
    HeapWord* res = object_space()->cas_allocate(word_size);
    if (res != nullptr) {
      _start_array->update_for_block(res, res + word_size);
    }
    return res;
  }

[albertnetymk]

Do we also want to follow this up to rename the allocate method in PSOldGen to cas_allocate?

Created a followup ticket: https://bugs.openjdk.org/browse/JDK-8380564

[albertnetymk]

Thanks for review.

/integrate

[openjdk]

Going to push as commit 4df61ce.
Since your change was applied there have been 23 commits pushed to the master branch:

• db49e8d: 8378243: [IR Framework] Create separate VMInfo and ApplicableIRRules JavaMessage classes
• 206c9cd: 8378923: Remove AppContext from datatransfer classes
• 8e906dd: 8379019: Remove AppContext from WindowEvent
• ... and 20 more: https://git.openjdk.org/jdk/compare/f5fbb6a237f022b485dbc79b6ec819df65535ffe...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 4df61ce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.