8380549: HttpCookie.expiryDate2DeltaSeconds returns 0 on parse failure, causing immediate cookie expiration#30341
Open
ehs208 wants to merge 1 commit intoopenjdk:masterfrom
Open
Conversation
…e, causing immediate cookie expiration
|
👋 Welcome back ehs208! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
expiryDate2DeltaSeconds()fails to parse the Expires attribute against all date formats, it returns 0. The caller inassignMaxAgeAttribute()then setsmaxAge=0, which causeshasExpired()to return true. Per RFC 6265 section 5.2.1, an unparseable Expires value should be ignored, leavingmaxAge=-1(session cookie).This fix introduces a sentinel constant (
Long.MIN_VALUE) as the return value for parse failure, since 0 is a valid delta for dates that match the creation time. The caller checks for this sentinel and skips the maxAge assignment when parsing fails.A new test in
MaxAgeExpiresverifies that unparseable Expires values are correctly ignored.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30341/head:pull/30341$ git checkout pull/30341Update a local copy of the PR:
$ git checkout pull/30341$ git pull https://git.openjdk.org/jdk.git pull/30341/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30341View PR using the GUI difftool:
$ git pr show -t 30341Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30341.diff
Using Webrev
Link to Webrev Comment