Skip to content

8374497: C2: assert(verify(phase)) failed: missing Value() optimization with -XX:+StressReflectiveCode#30342

Open
krk wants to merge 1 commit intoopenjdk:masterfrom
krk:fix-misval-reflect-8374497
Open

8374497: C2: assert(verify(phase)) failed: missing Value() optimization with -XX:+StressReflectiveCode#30342
krk wants to merge 1 commit intoopenjdk:masterfrom
krk:fix-misval-reflect-8374497

Conversation

@krk
Copy link

@krk krk commented Mar 20, 2026

verify() calls static_subtype_check with default skip=StressReflectiveCode, but sub() passes skip=false. Pass skip=false in verify() to match.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374497: C2: assert(verify(phase)) failed: missing Value() optimization with -XX:+StressReflectiveCode (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30342/head:pull/30342
$ git checkout pull/30342

Update a local copy of the PR:
$ git checkout pull/30342
$ git pull https://git.openjdk.org/jdk.git pull/30342/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30342

View PR using the GUI difftool:
$ git pr show -t 30342

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30342.diff

Using Webrev

Link to Webrev Comment

@krk krk force-pushed the fix-misval-reflect-8374497 branch from 286eac4 to b7337b9 Compare March 20, 2026 17:24
@krk krk changed the title C2: assert(verify(phase)) failed: missing Value() optimization with -XX:+StressReflectiveCode 8374497: C2: assert(verify(phase)) failed: missing Value() optimization with -XX:+StressReflectiveCode Mar 20, 2026
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 20, 2026

👋 Welcome back krk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 20, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Mar 20, 2026

@krk Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 20, 2026
@openjdk
Copy link

openjdk bot commented Mar 20, 2026

@krk The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 20, 2026
@mlbridge
Copy link

mlbridge bot commented Mar 20, 2026

Webrevs

@sarannat
Copy link
Contributor

Thank you for the update. I am going to run some testing and review this in more details.
I have a small comment, the copyright information needs fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants