Skip to content

8379551: sun/text/IntHashtable/Bug4705389.java timed out#30343

Closed
naotoj wants to merge 1 commit intoopenjdk:masterfrom
naotoj:JDK-8379551-Bug4705389-timed-out
Closed

8379551: sun/text/IntHashtable/Bug4705389.java timed out#30343
naotoj wants to merge 1 commit intoopenjdk:masterfrom
naotoj:JDK-8379551-Bug4705389-timed-out

Conversation

@naotoj
Copy link
Copy Markdown
Member

@naotoj naotoj commented Mar 20, 2026

Removing the arbitrary time out value from the test case. The time out value seems to have been there for the stop-gap to prevent the infinite loop in the bug case. Without the explicit time out, the jtreg's default time out would kick in, with more detailed thread dumps. (This PR is not intended to fix the intermittent issue described in the bug report which occurred in Valhalla repo, but to better analyse it if the same timeout occurs)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8379551: sun/text/IntHashtable/Bug4705389.java timed out (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30343/head:pull/30343
$ git checkout pull/30343

Update a local copy of the PR:
$ git checkout pull/30343
$ git pull https://git.openjdk.org/jdk.git pull/30343/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30343

View PR using the GUI difftool:
$ git pr show -t 30343

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30343.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 20, 2026

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 20, 2026

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8379551: sun/text/IntHashtable/Bug4705389.java timed out

Reviewed-by: liach, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 20, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 20, 2026

@naotoj The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 20, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Mar 20, 2026

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 20, 2026
@naotoj
Copy link
Copy Markdown
Member Author

naotoj commented Mar 23, 2026

Thanks for the reviews!
/integrate

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 23, 2026

Going to push as commit 0798dd1.
Since your change was applied there have been 44 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 23, 2026
@openjdk openjdk bot closed this Mar 23, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 23, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 23, 2026

@naotoj Pushed as commit 0798dd1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants