8378195: guarantee(static_cast<int>(_oops_size) == align_up(code_buffer->total_oop_size(), oopSize)) failed: failed: 12272 != 77808

[vnkozlov]

This issue occurs when JVMCI installs code that has too many embedded object references, triggering this limit check. JVMCI's field metadata_size have the same problem - 16 bits is not enough.

The change removes _oops_size field and change metadata_size filed's type to int.

_oops_size is not used after JDK-8343789 changes where we forgot to remove it. Because oops section is the last section in nmethod, its size is easy calculated without _oops_size field.

@dougxc is author of changes - he pushed it into Graal repository. I am testing and pushing into Open JDK.

Tested: tier1-4,hs-comp-stress

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8378195: guarantee(static_cast<int>(_oops_size) == align_up(code_buffer->total_oop_size(), oopSize)) failed: failed: 12272 != 77808 (Bug - P4)

Reviewers

• Doug Simon (@dougxc - Reviewer)

Contributors

• Doug Simon <dnsimon@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30355/head:pull/30355
$ git checkout pull/30355

Update a local copy of the PR:
$ git checkout pull/30355
$ git pull https://git.openjdk.org/jdk.git pull/30355/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30355

View PR using the GUI difftool:
$ git pr show -t 30355

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30355.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[vnkozlov]

/contributor add @dougxc

[openjdk]

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8378195: guarantee(static_cast<int>(_oops_size) == align_up(code_buffer->total_oop_size(), oopSize)) failed: failed: 12272 != 77808

Co-authored-by: Doug Simon <dnsimon@openjdk.org>
Reviewed-by: dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@vnkozlov
Contributor Doug Simon <dnsimon@openjdk.org> successfully added.

[openjdk]

@vnkozlov The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7914870a)