Skip to content

8385839: JMX config file correction#31354

Open
kevinjwalls wants to merge 1 commit into
openjdk:masterfrom
kevinjwalls:jmx_config_correction
Open

8385839: JMX config file correction#31354
kevinjwalls wants to merge 1 commit into
openjdk:masterfrom
kevinjwalls:jmx_config_correction

Conversation

@kevinjwalls
Copy link
Copy Markdown
Contributor

@kevinjwalls kevinjwalls commented Jun 2, 2026

A mistake from the original commit where the hashed passwords feature was added.

The example at the end of the template file is malformed, some original plaintext is left in when showing the example of how it would be replaced with hashes.

While we are here, removing a line that mentions Security Manager.

This is all comments, no code is changed.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31354/head:pull/31354
$ git checkout pull/31354

Update a local copy of the PR:
$ git checkout pull/31354
$ git pull https://git.openjdk.org/jdk.git pull/31354/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31354

View PR using the GUI difftool:
$ git pr show -t 31354

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31354.diff

Using Webrev

Link to Webrev Comment

@kevinjwalls kevinjwalls marked this pull request as ready for review June 2, 2026 19:49
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Jun 2, 2026

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Jun 2, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the serviceability serviceability-dev@openjdk.org label Jun 2, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Jun 2, 2026

@kevinjwalls The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 2, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Jun 2, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant