8301626: Capture Named Group information in TLSHandshakeEvent#31371
8301626: Capture Named Group information in TLSHandshakeEvent#31371seanjmullan wants to merge 2 commits into
Conversation
|
👋 Welcome back mullan! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
Bot
added
security
|
@seanjmullan The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
| // handshake context cleanup. | ||
| chc.handshakeFinished = true; | ||
| recordEvent(chc.conContext.conSession); | ||
| recordEvent(chc); |
There was a problem hiding this comment.
We record an event both on consuming and on producing Finished:
- Would there be any difference between those 2 events? AFAICT all the event's fields should be equal.
- How do we differentiate between consuming and producing events?
There was a problem hiding this comment.
Nevermind, I see now that we actually log only once on each side: client producing and server consuming.
| public String protocolVersion; | ||
| public String cipherSuite; | ||
| public long certificateId; | ||
| public String namedGroup; |
There was a problem hiding this comment.
Nit: namedGroup is being logged right after cipherSuite, it will be consistent to keep the same order here and in src/jdk.jfr/share/classes/jdk/jfr/events/TLSHandshakeEvent.java
2 participants
This change adds the negotiated named group to the JFR TLSHandshakeEvent.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31371/head:pull/31371$ git checkout pull/31371Update a local copy of the PR:
$ git checkout pull/31371$ git pull https://git.openjdk.org/jdk.git pull/31371/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31371View PR using the GUI difftool:
$ git pr show -t 31371Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31371.diff
Using Webrev
Link to Webrev Comment