8381235: TestCompileTaskTimeout intermittently fails due to unexpected exit code 1

[mhaessig]

TestCompileTaskTimeout.java fails when core dumps are disabled as asserts will then exit with exit code 1 instead of 134. This PR addresses this by only requiring a non-zero exit code. That is sufficient because the succeeding check ensures that there was an assert with the expected text.

Testing:

• Github Actions
• tier1,tier2 plus additional stress testing

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8381235: TestCompileTaskTimeout intermittently fails due to unexpected exit code 1 (Bug - P4)

Reviewers

• Dean Long (@dean-long - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31374/head:pull/31374
$ git checkout pull/31374

Update a local copy of the PR:
$ git checkout pull/31374
$ git pull https://git.openjdk.org/jdk.git pull/31374/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31374

View PR using the GUI difftool:
$ git pr show -t 31374

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31374.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mhaessig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8381235: TestCompileTaskTimeout intermittently fails due to unexpected exit code 1

Reviewed-by: dlong, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• c4a3373: 8385885: Clarify comment in LazyConstantImpl
• ee53e75: 8381812: The synthetic $deserializeLambda$ is notably bigger
• c6f9c23: 8385054: Spec: Clarify ofLazy List/Set/Map equals/hashCode/toString Javadoc
• ... and 21 more: https://git.openjdk.org/jdk/compare/ec1bffd9a51ae06479a261a6a106f44866212ae7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mhaessig The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-compiler. This can be overridden with the /reviewers command.

[mlbridge]

Webrevs

• 01: Full - Incremental (2b38f494)
• 00: Full (432ac703)

[mhaessig]

Thank you for reviewing, @dean-long. I noticed that I updated the copyright notice incorrectly and fixed it in the latest commit. Would you mind rereviewing?

[vnkozlov]

Good.

[mhaessig]

Thank you for reviewing @dean-long & @vnkozlov!

/integrate

[openjdk]

Going to push as commit f8f7ad2.
Since your change was applied there have been 24 commits pushed to the master branch:

• c4a3373: 8385885: Clarify comment in LazyConstantImpl
• ee53e75: 8381812: The synthetic $deserializeLambda$ is notably bigger
• c6f9c23: 8385054: Spec: Clarify ofLazy List/Set/Map equals/hashCode/toString Javadoc
• ... and 21 more: https://git.openjdk.org/jdk/compare/ec1bffd9a51ae06479a261a6a106f44866212ae7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mhaessig Pushed as commit f8f7ad2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.