Skip to content

8390284: javac does not consider the exporting default of automatic modules in --patch-module - #32481

Open
lahodaj wants to merge 5 commits into
openjdk:masterfrom
lahodaj:JDK-8390284
Open

8390284: javac does not consider the exporting default of automatic modules in --patch-module#32481
lahodaj wants to merge 5 commits into
openjdk:masterfrom
lahodaj:JDK-8390284

Conversation

@lahodaj

@lahodaj lahodaj commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

When constructing the model for automatic modules, javac ignores the patch module location. This PR is fixing that - the patch locations are considered when detecting automatic module packages/exports.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8390284: javac does not consider the exporting default of automatic modules in --patch-module

Issue

  • JDK-8390284: javac does not consider the exporting default of automatic modules in --patch-module (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32481/head:pull/32481
$ git checkout pull/32481

Update a local copy of the PR:
$ git checkout pull/32481
$ git pull https://git.openjdk.org/jdk.git pull/32481/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32481

View PR using the GUI difftool:
$ git pr show -t 32481

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32481.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Aug 21, 2026

Copy link
Copy Markdown

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 21, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the compiler compiler-dev@openjdk.org label Aug 21, 2026
@openjdk

openjdk Bot commented Aug 21, 2026

Copy link
Copy Markdown

@lahodaj The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Aug 21, 2026
@mlbridge

mlbridge Bot commented Aug 21, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler compiler-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant