Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8348110: Update LCMS to 2.17 #3015

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Mar 21, 2025

Update of the in-tree copy of LCMS to 2.17. Patch from 17u required no manual intervention to apply to 11u and built fine locally.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8348110 needs maintainer approval

Issue

  • JDK-8348110: Update LCMS to 2.17 (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3015/head:pull/3015
$ git checkout pull/3015

Update a local copy of the PR:
$ git checkout pull/3015
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3015/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3015

View PR using the GUI difftool:
$ git pr show -t 3015

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3015.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 21, 2025

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 763ee0a7e5bb6e9bdbf739e886d7c47bb28ea2b0 8348110: Update LCMS to 2.17 Mar 21, 2025
@openjdk
Copy link

openjdk bot commented Mar 21, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 21, 2025

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 21, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 21, 2025

Webrevs

@gnu-andrew
Copy link
Member Author

/approval request Regular update to the bundled copy of LCMS. Patch applied as is to 11u, built fine locally and on GHA. GHA testing passes without regression.

@openjdk
Copy link

openjdk bot commented Mar 25, 2025

@gnu-andrew
8348110: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant