Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8352716: (tz) Update Timezone Data to 2025b #3020

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

satyenme
Copy link

@satyenme satyenme commented Mar 31, 2025

Backport of tzdata2025b. Nearly clean, but contains zone.tab file, which was removed by JDK-8166983.

Reverted change to test/jdk/java/util/TimeZone/TimeZoneData/aliases.txt and .../displaynames.txt when running make in test/jdk/java/util/TimeZone/tools/share to avoid the java/util/TimeZone/Bug6329116.java test failing, just as was done previously for 2024b.

Passed tier1 tests and make run-test TEST="jdk/java/util/TimeZone jdk/java/time/test jdk/sun/util/resources jdk/sun/text/resources jdk/sun/util/calendar" locally, GHA sanity tests (other than known failure).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8352716 needs maintainer approval

Issue

  • JDK-8352716: (tz) Update Timezone Data to 2025b (Enhancement - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3020/head:pull/3020
$ git checkout pull/3020

Update a local copy of the PR:
$ git checkout pull/3020
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3020/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3020

View PR using the GUI difftool:
$ git pr show -t 3020

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3020.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 31, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 31, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 1d205f5f0704f251eb68165f3caf1e70d542ae63 8352716: (tz) Update Timezone Data to 2025b Mar 31, 2025
@openjdk
Copy link

openjdk bot commented Mar 31, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 31, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 31, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 31, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@satyenme
Copy link
Author

satyenme commented Apr 1, 2025

/approval request for backport of 2025b tzdata. Nearly clean, but needed to re-add zone.tab file, which was removed by JDK-8166983.

Risk: Medium to Low. Tier 1 and relevant tz tests passing, as well as GHA sanity check tests. Backporting tzdata changes is a common enough procedure that, after review, we can be reasonably confident will work as intended.

Testing:

  • GHA Sanity Checks (with 1 known, unrelated failure)
  • Tier 1 tests locally
  • make run-test TEST="jdk/java/util/TimeZone jdk/java/time/test jdk/sun/util/resources jdk/sun/text/resources jdk/sun/util/calendar"

@openjdk
Copy link

openjdk bot commented Apr 1, 2025

@satyenme
8352716: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants