Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout #3022

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phohensee
Copy link
Member

@phohensee phohensee commented Apr 4, 2025

Backport for parity with Oracle 11.0.28. Clean except for copyright date adjustment, low risk: test only, modified test passes, eliminates warning.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8345133 needs maintainer approval

Issue

  • JDK-8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3022/head:pull/3022
$ git checkout pull/3022

Update a local copy of the PR:
$ git checkout pull/3022
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3022/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3022

View PR using the GUI difftool:
$ git pr show -t 3022

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3022.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2025

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 153dc6d84300e4c3446e33be820c15336cf45e72 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout Apr 4, 2025
@openjdk
Copy link

openjdk bot commented Apr 4, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

⚠️ @phohensee This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 4, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 4, 2025

Webrevs

@phohensee
Copy link
Member Author

/approval request Backport for parity with Oracle 11.0.28. Clean except for copyright date adjustment, low risk: test only, modified test passes, eliminates warning.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@phohensee
8345133: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant