Skip to content

8348597: Update HarfBuzz to 10.4.0 #3026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vieiro
Copy link
Contributor

@vieiro vieiro commented Apr 25, 2025

Backport of JDK-8348597 from JDK17 that updates HarfBuzz to 10.4.0 (which improves drawing performande by 10+% and includes different build fixes). Backport is not clean because it required adapting make/lib/Awt2dLibraries.gmk to fit JDK11.

Even though the backport built correctly, the resulting jdk/lib/libfontmanager.so contained undefined symbols that caused Swing tests to fail with UnsatisfiedLinkError. This is because JDK11 is missing JDK-8319197 that excludes hb-subset from compilation, so this is also included as the second commit in the pull request.

While at it, a third commit adds an additional -Wno-attributes flag to HARFBUZZ_DISABLED_WARNINGS_CXX_gcc, restoring the capability to build JDK11 on Linux with gcc-4.8.5 (this is an old version of gcc, dating from 2015, but it's still the system gcc version in RHEL-7).

Tested

  • on Windows 10 with jdk:jfc_demo.
  • on Linux with jdk:jfc_demo, with
    • gcc 4.8.5/harfbuzz-1.7.5 (x86_64 & s390x),
    • gcc 8.5.0/harfbuzz-1.7.5 (x86_64),
    • gcc 11.5.0/harfbuzz-2.7.4 (x86_64)
    • and gcc 14.2.1/harfbuzz-9.0.0 (x86_64)

with both --with-harfbuzz=system and --with-harfbuzz=bundled.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8348597 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8319197 needs maintainer approval

Issues

  • JDK-8348597: Update HarfBuzz to 10.4.0 (Bug - P3)
  • JDK-8319197: Exclude hb-subset and hb-style from compilation (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3026/head:pull/3026
$ git checkout pull/3026

Update a local copy of the PR:
$ git checkout pull/3026
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3026/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3026

View PR using the GUI difftool:
$ git pr show -t 3026

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3026.diff

Using Webrev

Link to Webrev Comment

@vieiro
Copy link
Contributor Author

vieiro commented Apr 25, 2025

/issue add JDK-8334964

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2025

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 25, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 25, 2025
@openjdk
Copy link

openjdk bot commented Apr 25, 2025

@vieiro
Adding additional issue to issue list: 8334964: Exclude hb-subset and hb-style from compilation.

@vieiro vieiro changed the title 8348597: Update HarfBuzz to 10.4.0 Backport ba3db307dceb41e48014451873fdf4db3816a537 Apr 25, 2025
@openjdk openjdk bot changed the title Backport ba3db307dceb41e48014451873fdf4db3816a537 8319197: Exclude hb-subset and hb-style from compilation Apr 25, 2025
@openjdk
Copy link

openjdk bot commented Apr 25, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Apr 25, 2025
@vieiro vieiro changed the title 8319197: Exclude hb-subset and hb-style from compilation Backport f4e99de33e35826ec1fb368d6ad96005d7bd5cc4 Apr 25, 2025
@openjdk openjdk bot changed the title Backport f4e99de33e35826ec1fb368d6ad96005d7bd5cc4 8348597: Update HarfBuzz to 10.4.0 Apr 25, 2025
@openjdk
Copy link

openjdk bot commented Apr 25, 2025

This backport pull request has now been updated with issue from the original commit.

@mlbridge
Copy link

mlbridge bot commented Apr 25, 2025

Webrevs

@vieiro
Copy link
Contributor Author

vieiro commented Apr 25, 2025

Fixing issues:
/issue add JDK-8319197
/issue remove JDK-8334964

@openjdk
Copy link

openjdk bot commented Apr 25, 2025

@vieiro
Adding additional issue to issue list: 8319197: Exclude hb-subset and hb-style from compilation.

@openjdk
Copy link

openjdk bot commented Apr 25, 2025

@vieiro
Removing additional issue from issue list: 8334964.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant