-
Notifications
You must be signed in to change notification settings - Fork 238
8348597: Update HarfBuzz to 10.4.0 #3026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
/issue add JDK-8334964 |
👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@vieiro |
This backport pull request has now been updated with issue from the original commit. |
This backport pull request has now been updated with issue from the original commit. |
Fixing issues: |
@vieiro |
@vieiro |
Backport of JDK-8348597 from JDK17 that updates HarfBuzz to 10.4.0 (which improves drawing performande by 10+% and includes different build fixes). Backport is not clean because it required adapting
make/lib/Awt2dLibraries.gmk
to fit JDK11.Even though the backport built correctly, the resulting
jdk/lib/libfontmanager.so
contained undefined symbols that caused Swing tests to fail withUnsatisfiedLinkError
. This is because JDK11 is missing JDK-8319197 that excludes hb-subset from compilation, so this is also included as the second commit in the pull request.While at it, a third commit adds an additional
-Wno-attributes
flag toHARFBUZZ_DISABLED_WARNINGS_CXX_gcc
, restoring the capability to build JDK11 on Linux withgcc-4.8.5
(this is an old version of gcc, dating from 2015, but it's still the system gcc version in RHEL-7).Tested
jdk:jfc_demo
.jdk:jfc_demo
, withgcc 4.8.5/harfbuzz-1.7.5 (x86_64 & s390x)
,gcc 8.5.0/harfbuzz-1.7.5 (x86_64)
,gcc 11.5.0/harfbuzz-2.7.4 (x86_64)
gcc 14.2.1/harfbuzz-9.0.0 (x86_64)
with both
--with-harfbuzz=system
and--with-harfbuzz=bundled
.Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3026/head:pull/3026
$ git checkout pull/3026
Update a local copy of the PR:
$ git checkout pull/3026
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3026/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3026
View PR using the GUI difftool:
$ git pr show -t 3026
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3026.diff
Using Webrev
Link to Webrev Comment