Skip to content

8286204: [Accessibility,macOS,VoiceOver] VoiceOver reads the spinner value 10 as 1 when user iterates to 10 for the first time on macOS #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 17, 2025

I backport this for parity with 17.0.16-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8286204 needs maintainer approval

Issue

  • JDK-8286204: [Accessibility,macOS,VoiceOver] VoiceOver reads the spinner value 10 as 1 when user iterates to 10 for the first time on macOS (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3366/head:pull/3366
$ git checkout pull/3366

Update a local copy of the PR:
$ git checkout pull/3366
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3366/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3366

View PR using the GUI difftool:
$ git pr show -t 3366

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3366.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 17, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 17, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286204: [Accessibility,macOS,VoiceOver] VoiceOver reads the spinner value 10 as 1 when user iterates to 10 for the first time on macOS

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport cd9f1d3d921531511a7552807d099d5d3cce01a6 8286204: [Accessibility,macOS,VoiceOver] VoiceOver reads the spinner value 10 as 1 when user iterates to 10 for the first time on macOS Mar 17, 2025
@openjdk
Copy link

openjdk bot commented Mar 17, 2025

This backport pull request has now been updated with issue from the original commit.

@GoeLin GoeLin marked this pull request as ready for review April 10, 2025 21:10
@openjdk
Copy link

openjdk bot commented Apr 10, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 10, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 10, 2025

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 11, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 14, 2025

@GoeLin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@GoeLin
Copy link
Member Author

GoeLin commented Apr 16, 2025

/integrate

@GoeLin
Copy link
Member Author

GoeLin commented Apr 16, 2025

GHA failure: Artifact not found for name: bundles-jtreg-7.3.1+1, unrelated

@openjdk
Copy link

openjdk bot commented Apr 16, 2025

Going to push as commit 45b84ae.
Since your change was applied there have been 48 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 16, 2025
@openjdk openjdk bot closed this Apr 16, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 16, 2025
@openjdk
Copy link

openjdk bot commented Apr 16, 2025

@GoeLin Pushed as commit 45b84ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant