Skip to content

8341447: Open source closed frame tests # 5 #3482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 10, 2025

I backport this for parity with 17.0.16-oracle.

Resolved ProblemList, probably clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8341447 needs maintainer approval

Issue

  • JDK-8341447: Open source closed frame tests # 5 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3482/head:pull/3482
$ git checkout pull/3482

Update a local copy of the PR:
$ git checkout pull/3482
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3482/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3482

View PR using the GUI difftool:
$ git pr show -t 3482

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3482.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 10, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 10, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341447: Open source closed frame tests # 5

Reviewed-by: rschmelter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 966eb7232ff867d9a68269d5a2007da20259565f 8341447: Open source closed frame tests # 5 Apr 10, 2025
@openjdk
Copy link

openjdk bot commented Apr 10, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 10, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 10, 2025

Webrevs

@GoeLin GoeLin force-pushed the goetz_backport_8341447 branch from 5916cdd to 27b7648 Compare April 10, 2025 21:06
@openjdk
Copy link

openjdk bot commented Apr 10, 2025

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

Copy link
Contributor

@schmelter-sap schmelter-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Apr 11, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 11, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Apr 16, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Apr 16, 2025

Going to push as commit c395a99.
Since your change was applied there have been 41 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 16, 2025
@openjdk openjdk bot closed this Apr 16, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 16, 2025
@openjdk
Copy link

openjdk bot commented Apr 16, 2025

@GoeLin Pushed as commit c395a99.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8341447 branch April 16, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants