-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8342958: Use jvmArgs consistently in microbenchmarks #1403
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
/issue JDK-8343345 |
@sendaoYan |
Backport to fix several JMH test bugs and make using jvmArgs consistently. Change has been verified locally, test-fix only, no risk. |
Hi all,
Why this backport can not backport cleanly?
Testing:
Test commands:
Test result:
5 tests fails, the fails unrelated to this PR, I have create a new issue to record this failure. All other tests passes.
jmh-result.zip
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1403/head:pull/1403
$ git checkout pull/1403
Update a local copy of the PR:
$ git checkout pull/1403
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1403/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1403
View PR using the GUI difftool:
$ git pr show -t 1403
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1403.diff
Using Webrev
Link to Webrev Comment