Skip to content

8317264: Pattern.Bound has static fields that should be static final. #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fandreuz
Copy link

@fandreuz fandreuz commented Apr 9, 2025

Clean backport of JDK-8317264. The fields are never assigned after initialization. final leads to shorter bytecode. It's a minor performance optimization in Regex.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317264 needs maintainer approval

Error

 ⚠️ OCA signatory status must be verified

Warning

 ⚠️ Found trailing period in issue title for 8317264: Pattern.Bound has staticfields that should bestatic final.

Issue

  • JDK-8317264: Pattern.Bound has static fields that should be static final. (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1622/head:pull/1622
$ git checkout pull/1622

Update a local copy of the PR:
$ git checkout pull/1622
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1622/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1622

View PR using the GUI difftool:
$ git pr show -t 1622

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1622.diff

@fandreuz fandreuz changed the title Backport ecb5e8a03f67c92d7956201de1fa7d07cc6af9cb 8317264 Backport ecb5e8a03f67c92d7956201de1fa7d07cc6af9cb Apr 9, 2025
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Apr 9, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 9, 2025

Hi @fandreuz, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user fandreuz" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Apr 9, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@fandreuz
Copy link
Author

fandreuz commented Apr 9, 2025

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Apr 9, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 9, 2025

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@openjdk openjdk bot changed the title Backport ecb5e8a03f67c92d7956201de1fa7d07cc6af9cb 8317264: Pattern.Bound has static fields that should be static final. Apr 9, 2025
@openjdk
Copy link

openjdk bot commented Apr 9, 2025

This backport pull request has now been updated with issue from the original commit.

@fandreuz fandreuz changed the title 8317264: Pattern.Bound has static fields that should be static final. 8317264: Pattern.Bound has static fields that should be static final Apr 9, 2025
@openjdk openjdk bot changed the title 8317264: Pattern.Bound has static fields that should be static final 8317264: Pattern.Bound has static fields that should be static final. Apr 9, 2025
@fandreuz fandreuz force-pushed the JDK-8317264-final-fields-bound branch from c686479 to 1c96448 Compare April 9, 2025 15:33
@openjdk
Copy link

openjdk bot commented Apr 9, 2025

@fandreuz Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@phohensee
Copy link
Member

I can confirm that @fandreuz is an Amazon employee and covered by the OCA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

2 participants