Skip to content

8335643: serviceability/dcmd/vm tests fail for ZGC after JDK-8322475 #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ansteiner
Copy link

@ansteiner ansteiner commented Apr 9, 2025

Backport of 3cce31ad8877ec62429981871bcb0067770f9ccb

Reviewed-by: sgehwolf, dholmes
(cherry picked from commit 3cce31ad8877ec62429981871bcb0067770f9ccb)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8335643 needs maintainer approval

Issue

  • JDK-8335643: serviceability/dcmd/vm tests fail for ZGC after JDK-8322475 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1624/head:pull/1624
$ git checkout pull/1624

Update a local copy of the PR:
$ git checkout pull/1624
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1624/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1624

View PR using the GUI difftool:
$ git pr show -t 1624

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1624.diff

Using Webrev

Link to Webrev Comment

ansteiner and others added 2 commits April 9, 2025 11:00
Reviewed-by: sgehwolf, dholmes
(cherry picked from commit 3cce31ad8877ec62429981871bcb0067770f9ccb)
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 9, 2025

👋 Welcome back asteiner! A progress list of the required criteria for merging this PR into pr/1619 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 9, 2025

@ansteiner This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335643: serviceability/dcmd/vm tests fail for ZGC after JDK-8322475

Reviewed-by: goetz, stuefe
Backport-of: 3cce31ad8877ec62429981871bcb0067770f9ccb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • c98682d: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to main program
  • 9c5807b: 8312475: org.jline.util.PumpReader signed byte problem

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tstuefe, @GoeLin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 9, 2025
@ansteiner ansteiner changed the title 8335643: serviceability/dcmd/vm tests fail for ZGC after JDK-8322475 Backport 3cce31ad8877ec62429981871bcb0067770f9ccb Apr 9, 2025
@openjdk openjdk bot changed the title Backport 3cce31ad8877ec62429981871bcb0067770f9ccb 8335643: serviceability/dcmd/vm tests fail for ZGC after JDK-8322475 Apr 9, 2025
@openjdk
Copy link

openjdk bot commented Apr 9, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Apr 9, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 9, 2025

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ansteiner
Copy link
Author

/approval request Fix the failing test for ZGC after 8322475

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/1619 to master April 15, 2025 07:47
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout backport_3cce31ad8877ec62429981871bcb0067770f9ccb
git fetch https://git.openjdk.org/jdk21u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Apr 15, 2025

⚠️ @ansteiner This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Apr 15, 2025

@ansteiner
8335643: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 15, 2025
@openjdk openjdk bot removed the approval label Apr 15, 2025
Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omitted changes to problem list as the tests are not problem listed in 21.
Re-review needed after merging predecessor change.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 15, 2025
@ansteiner
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 15, 2025
@openjdk
Copy link

openjdk bot commented Apr 15, 2025

@ansteiner
Your change (at version ff12f2c) is now ready to be sponsored by a Committer.

@MBaesken
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 15, 2025

Going to push as commit a98ea66.
Since your change was applied there have been 4 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 15, 2025
@openjdk openjdk bot closed this Apr 15, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Apr 15, 2025
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 15, 2025
@openjdk
Copy link

openjdk bot commented Apr 15, 2025

@MBaesken @ansteiner Pushed as commit a98ea66.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants