-
Notifications
You must be signed in to change notification settings - Fork 120
8335643: serviceability/dcmd/vm tests fail for ZGC after JDK-8322475 #1624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8335643: serviceability/dcmd/vm tests fail for ZGC after JDK-8322475 #1624
Conversation
Reviewed-by: sgehwolf, dholmes (cherry picked from commit 3cce31ad8877ec62429981871bcb0067770f9ccb)
👋 Welcome back asteiner! A progress list of the required criteria for merging this PR into |
@ansteiner This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tstuefe, @GoeLin) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
/approval request Fix the failing test for ZGC after 8322475 |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout backport_3cce31ad8877ec62429981871bcb0067770f9ccb
git fetch https://git.openjdk.org/jdk21u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
@ansteiner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Omitted changes to problem list as the tests are not problem listed in 21.
Re-review needed after merging predecessor change.
/integrate |
@ansteiner |
/sponsor |
Going to push as commit a98ea66.
Your commit was automatically rebased without conflicts. |
@MBaesken @ansteiner Pushed as commit a98ea66. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of 3cce31ad8877ec62429981871bcb0067770f9ccb
Reviewed-by: sgehwolf, dholmes
(cherry picked from commit 3cce31ad8877ec62429981871bcb0067770f9ccb)
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1624/head:pull/1624
$ git checkout pull/1624
Update a local copy of the PR:
$ git checkout pull/1624
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1624/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1624
View PR using the GUI difftool:
$ git pr show -t 1624
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1624.diff
Using Webrev
Link to Webrev Comment