Skip to content

8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jankratochvil
Copy link

@jankratochvil jankratochvil commented Apr 15, 2025

A patch 4 of 6 for: [21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected

It has a patch dependency on PR 3 of 6: #1650

This backport is clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331560 needs maintainer approval

Issue

  • JDK-8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1651/head:pull/1651
$ git checkout pull/1651

Update a local copy of the PR:
$ git checkout pull/1651
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1651/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1651

View PR using the GUI difftool:
$ git pr show -t 1651

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1651.diff

Using Webrev

Link to Webrev Comment

jerboaa and others added 5 commits April 14, 2025 15:42
Reviewed-by: sgehwolf, clanger, stuefe
…ndefined reference to `JVM_IsContainerized'

 - a patch by Yuri Nesterenko
…n outside a container

Reviewed-by: stuefe, iklam
…delegates to controllers

Reviewed-by: jsjolen, stuefe
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 15, 2025

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 15, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 65a282aae3f81379f1471db4fc0ff2e3b479140e 8331560: Refactor Hotspot container detection code so that subsystem delegates to controllers Apr 15, 2025
@openjdk
Copy link

openjdk bot commented Apr 15, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 15, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 15, 2025

Webrevs

@jankratochvil
Copy link
Author

Replaced by: #1662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants