Skip to content

8333326: Linux Alpine build fails after 8302744 #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: pr/1648
Choose a base branch
from

Conversation

jankratochvil
Copy link

@jankratochvil jankratochvil commented Apr 16, 2025

A patch 2 of 6 for: [21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected

It has a patch dependency on PR 1 of 6: #1648

This backport is clean.

The whole patchset has been tested on CentOS-7.9 (for cgroup v1) and on Fedora 40 (for cgroup v2) for test/hotspot/jtreg/containers.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8333326 needs maintainer approval

Integration blocker

 ⚠️ Dependency #1648 must be integrated first

Issue

  • JDK-8333326: Linux Alpine build fails after 8302744 (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1660/head:pull/1660
$ git checkout pull/1660

Update a local copy of the PR:
$ git checkout pull/1660
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1660/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1660

View PR using the GUI difftool:
$ git pr show -t 1660

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1660.diff

Using Webrev

Link to Webrev Comment

Reviewed-by: sgehwolf, clanger, stuefe
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 16, 2025

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into pr/1648 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport e67c30408218ed5737f26e3924095396febf6cda 8333326: Linux Alpine build fails after 8302744 Apr 16, 2025
@openjdk
Copy link

openjdk bot commented Apr 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Apr 16, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 16, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants