8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree

[GoeLin]

I backport this for parity with 21.0.8-oracle. I had to resolve a row of simple conflicts. The first commit contains all the clean parts.

test/jdk/java/security/Provider/ChangeProviders.java
Trivial resolve because "https://bugs.openjdk.org/browse/JDK-8175874: Update Security.insertProviderAt to specify behavior when requested position is out of range." missing.
Specification change with CSR, don't backport.

All Copyright because "https://bugs.openjdk.org/browse/JDK-8338411: Implement JEP 486: Permanently Disable the Security Manager" touched these files.
test/jdk/sun/security/pkcs11/ec/ReadCertificates.java
test/jdk/sun/security/pkcs11/ec/ReadPKCS12.java
test/jdk/sun/security/pkcs11/ec/TestECDH.java
test/jdk/sun/security/pkcs11/ec/TestECDH2.java
test/jdk/sun/security/pkcs11/ec/TestECDSA.java
test/jdk/sun/security/pkcs11/ec/TestECDSA2.java
test/jdk/sun/security/pkcs11/rsa/TestCACerts.java
test/jdk/sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java

test/jdk/sun/security/provider/certpath/PKIXCertComparator/Order.java
Test added by "https://bugs.openjdk.org/browse/JDK-8317431: Implement simpler Comparator when building certification paths" (jdk23). Enhancement, not a
candidate for backport. Omitted.

test/jdk/sun/security/ssl/Stapling/StatusResponseManager.java
test/jdk/sun/security/ssl/Stapling/java.base/sun/security/ssl/StatusResponseManagerTests.java
Trivial resolves because P4 bug "https://bugs.openjdk.org/browse/JDK-8339403: sun.security.ssl.StatusResponseManager.get swallows interrupt status" (jdk24) is not in 21.
Candidate for backport? Seems to be just a defensive change.

test/lib/jdk/test/lib/security/CertificateBuilder.java
Also "https://bugs.openjdk.org/browse/JDK-8317431: Implement simpler Comparator when building certification paths". Resolved Copyright.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8349501 needs maintainer approval

Issue

• JDK-8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree (Bug - P4 - Approved)

Reviewers

• Ralf Schmelter (@schmelter-sap - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1721/head:pull/1721
$ git checkout pull/1721

Update a local copy of the PR:
$ git checkout pull/1721
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1721/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1721

View PR using the GUI difftool:
$ git pr show -t 1721

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1721.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree

Reviewed-by: rschmelter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• c2228cc: 8320948: NPE due to unreported compiler error
• d5a2f76: 8318700: MacOS Zero cannot run gtests due to wrong JVM path
• ec177b8: 8319690: [AArch64] C2 compilation hits offset_ok_for_immed: assert "c2 compiler bug"
• ... and 2 more: https://git.openjdk.org/jdk21u-dev/compare/56b21a79469704ef342b5abdaa64a08fe8f31625...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (a0d2bcc9)

[schmelter-sap]

Looks good.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

Thanks for the review!

[GoeLin]

/integrate

[openjdk]

Going to push as commit fdd0cb5.
Since your change was applied there have been 7 commits pushed to the master branch:

• 20dc5eb: 8333680: com/sun/tools/attach/BasicTests.java fails with "SocketException: Permission denied: connect"
• 4398cce: 8333013: Update vmTestbase/nsk/share/LocalProcess.java to don't use finalization
• c2228cc: 8320948: NPE due to unreported compiler error
• ... and 4 more: https://git.openjdk.org/jdk21u-dev/compare/56b21a79469704ef342b5abdaa64a08fe8f31625...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit fdd0cb5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.