Skip to content

8318509: x86 count_positives intrinsic broken for -XX:AVX3Threshold=0 #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

satyenme
Copy link

@satyenme satyenme commented Apr 30, 2025

Backporting JDK-8318509: x86 count_positives intrinsic broken for -XX:AVX3Threshold=0. Fix pulls the value from tmp1, which contains the correct value. Adds test. Ran GHA Sanity Checks, local Tier 1 and 2, and new test/hotspot/jtreg/compiler/intrinsics/string/TestCountPositives.java tests. Patch is clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318509 needs maintainer approval

Issue

  • JDK-8318509: x86 count_positives intrinsic broken for -XX:AVX3Threshold=0 (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1726/head:pull/1726
$ git checkout pull/1726

Update a local copy of the PR:
$ git checkout pull/1726
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1726/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1726

View PR using the GUI difftool:
$ git pr show -t 1726

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1726.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 30, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 30, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport e67550cfec4dbd1c8c2c9869dda34fa09a5c274b 8318509: x86 count_positives intrinsic broken for -XX:AVX3Threshold=0 Apr 30, 2025
@openjdk
Copy link

openjdk bot commented Apr 30, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 30, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 30, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 30, 2025

Webrevs

@satyenme
Copy link
Author

satyenme commented May 1, 2025

/approval request for backport. Fix pulls the value from tmp1 variable, which contains the correct value in the problematic edge case.

Risk: Low. Tip change was merged in October 2023 and adjusts existing tests to confirm functionality is correct.

Testing:

  • GHA Sanity Checks
  • Tier 1 and 2 tests locally
  • Two tests adjusted by the backport

@openjdk
Copy link

openjdk bot commented May 1, 2025

@satyenme
8318509: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant