8317678: Fix up hashCode() for ZipFile.Source.Key

[satyenme]

Backporting JDK-8317678: Fix up hashCode() for ZipFile.Source.Key. Fixes java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source objects aren't created for the same zip file. Adds test. Ran GHA Sanity Checks, local Tier 1 and 2, and new test. Patch is clean.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8317678 needs maintainer approval

Issue

• JDK-8317678: Fix up hashCode() for ZipFile.Source.Key (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1729/head:pull/1729
$ git checkout pull/1729

Update a local copy of the PR:
$ git checkout pull/1729
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1729/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1729

View PR using the GUI difftool:
$ git pr show -t 1729

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1729.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 01: Full - Incremental (ebb9af07)
• 00: Full (c1cf0cc1)

[satyenme]

/approval request for backport. Fixes java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source objects aren't created for the same zip file.

Risk: Low. Tip change was merged in January 2023 and adds a test to confirm correct functionality.

Testing:

• GHA Sanity Checks
• Tier 1 and 2 tests locally
• New test/jdk/java/util/zip/ZipFile/ZipSourceCache.java test

[openjdk]

@satyenme
8317678: The approval request has been created successfully.

[GoeLin]

Hi @satyenme, can you please give a detailed reason why you think this should be fixed in 21?

Also, please do a dependent PR for the follow-up test fix JDK-8322078

[satyenme]

Since this is just a performance improvement, not high priority, closing