-
Notifications
You must be signed in to change notification settings - Fork 100
8359064: Expose reason for marking nmethod non-entrant to JVMCI client #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8359064: Expose reason for marking nmethod non-entrant to JVMCI client #335
Conversation
|
👋 Welcome back cslucas! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
Reviewed-by: aph, shade (cherry picked from commit ff54a6493a63cfbcaab7ec90c7db0135e98a7f0c)
|
/issue add JDK-8359064 |
|
@JohnTortugo This issue is referenced in the PR title - it will now be updated. |
|
/issue add JDK-8360049 |
|
@JohnTortugo |
|
/approval request This PR updates JVMCI interface to receive/send to the external compiler the reason why a nmethod is being invalidated. Most of the touched files in the PR are just hit by collateral effect due to constants' name renaming, though. Note that a second commit/issue was added to this PR to address a bug on the original patch. These original changes have been integrated in JDK mainline about 4 months ago. Besides GHA the current patch was also tested on my internal CI. |
|
@JohnTortugo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backport looks fine.
I do notice JDK-8360168 is still open, and there is JDK-8360169 problemlist addition. @RealFYang, are you OK with this going into 25u, or are you fixing the issue in mainline, or do you want to pick up problemlist patch as well?
Hi, Thanks for the ping. I think we need the problemlist patch for now. |
Hi all,
This pull request contains a backport of commit 2fe12984 from the openjdk/jdk repository.
The commit being backported was authored by Cesar Soares Lucas on 19 Jun 2025 and was reviewed by Doug Simon and Tom Rodriguez.
Thanks!
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/335/head:pull/335$ git checkout pull/335Update a local copy of the PR:
$ git checkout pull/335$ git pull https://git.openjdk.org/jdk25u.git pull/335/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 335View PR using the GUI difftool:
$ git pr show -t 335Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/335.diff
Using Webrev
Link to Webrev Comment