Skip to content

7904083: Print fatal error messages to stderr #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

7904083: Print fatal error messages to stderr #290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/share/bin/jtreg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ esac
JTREG_HOME=${JTREG_HOME:-$JT_HOME} # allow for old version of name
if [ -n "$JTREG_HOME" ]; then
if [ ! -r $JTREG_HOME/lib/jtreg.jar ];then
echo "Invalid JTREG_HOME=$JTREG_HOME. Cannot find or read $JTREG_HOME/lib/jtreg.jar"
exit 1;
echo "Invalid JTREG_HOME=$JTREG_HOME. Cannot find or read $JTREG_HOME/lib/jtreg.jar" >&2
exit 1
fi
else
# Deduce where script is installed
Expand All @@ -94,7 +94,8 @@ else
p=`dirname "$p"`
done
if [ -z "$JTREG_HOME" ]; then
echo "Cannot determine JTREG_HOME; please set it explicitly"; exit 1
echo "Cannot determine JTREG_HOME; please set it explicitly" >&2
exit 1
fi
fi

Expand Down Expand Up @@ -139,8 +140,8 @@ elif [ -n "$wsl" -a -x "$JTREG_JAVA".exe ]; then
fi

if [ ! -e "$JTREG_JAVA" ]; then
echo "No java executable at $JTREG_JAVA"
exit 1;
echo "No java executable at $JTREG_JAVA" >&2
exit 1
fi

# Verify java version 11 or newer used to run jtreg
Expand All @@ -149,11 +150,11 @@ version=`"$JTREG_JAVA" -classpath "${JTREG_HOME}/lib/jtreg.jar" com.sun.javatest
grep 'java.version=' | sed -e 's/^.*=//' -e 's/^1\.//' -e 's/\([1-9][0-9]*\).*/\1/'`

if [ -z "$version" ]; then
echo "Cannot determine version of java to run jtreg"
exit 1;
echo "Cannot determine version of java to run jtreg" >&2
exit 1
elif [ "$version" -lt 11 ]; then
echo "java version 11 or later is required to run jtreg"
exit 1;
echo "java version 11 or later is required to run jtreg" >&2
exit 1
fi

# Separate out -J* options for the JVM
Expand Down