8370659: [mobile] enable static-libs-image for Android #40
+69
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the changes required to compile libjvm.a and the classlibs using the latest upstream code.
Some notes:
To configure/make, the following configuration is recommended:
After configuring the build, run
make static-libs-imageNote that this requires Android NDK 29, which can be downloaded from https://developer.android.com/ndk/downloads
I only tested this using Linux. Mac/Windows builds may or may not work.
In
make/autoconf/flags-cflags.m4, the minimum android version is set to 32 (-target aarch64-linux-android32). The reason for this is that this version comes with a version of bionic that supports thr_current. This is not strictly needed, but lower versions would require more bionic-specific patches.I use
#ifdef __BIONIC__and similar in most places where we do "Android" specific checks. The reason for this is that those checks mainly refer to support that is (or isn't) available in Bionic. As such, it is better to compare e.g. bionic with musl and libc unless we are specifically using Android API'sI can provide a sample with a Makefile that validates the build on a real phone, but I think that is not in scope of this PR.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/mobile.git pull/40/head:pull/40$ git checkout pull/40Update a local copy of the PR:
$ git checkout pull/40$ git pull https://git.openjdk.org/mobile.git pull/40/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 40View PR using the GUI difftool:
$ git pr show -t 40Using diff file
Download this PR as a diff file:
https://git.openjdk.org/mobile/pull/40.diff
Using Webrev
Link to Webrev Comment