Make UseCompactObjectHeaders the default and adjust CDS archives.#2246
Draft
coleenp wants to merge 1 commit intoopenjdk:lworldfrom
Draft
Make UseCompactObjectHeaders the default and adjust CDS archives.#2246coleenp wants to merge 1 commit intoopenjdk:lworldfrom
coleenp wants to merge 1 commit intoopenjdk:lworldfrom
Conversation
|
👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes UseCompactObjectHeaders the default much like openjdk/jdk#30322
The archives here are for all the combinations.
classes_nocoh_preview.jsa
classes_nocoops_preview.jsa
classes_nocoh.jsa
classes_nocoops.jsa
classes_nocoops_nocoh_preview.jsa
classes_preview.jsa
classes_nocoops_nocoh.jsa
classes.jsa
Tested with tier1-8. Still working through the failed tests. Some are test errors. Will link them together.
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2246/head:pull/2246$ git checkout pull/2246Update a local copy of the PR:
$ git checkout pull/2246$ git pull https://git.openjdk.org/valhalla.git pull/2246/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2246View PR using the GUI difftool:
$ git pr show -t 2246Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2246.diff