Skip to content

Emit reference load#2453

Draft
rwestrel wants to merge 43 commits into
openjdk:lworldfrom
rwestrel:emit_reference_load
Draft

Emit reference load#2453
rwestrel wants to merge 43 commits into
openjdk:lworldfrom
rwestrel:emit_reference_load

Conversation

@rwestrel
Copy link
Copy Markdown
Collaborator

@rwestrel rwestrel commented May 19, 2026

XXX



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2453/head:pull/2453
$ git checkout pull/2453

Update a local copy of the PR:
$ git checkout pull/2453
$ git pull https://git.openjdk.org/valhalla.git pull/2453/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2453

View PR using the GUI difftool:
$ git pr show -t 2453

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2453.diff

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 19, 2026

👋 Welcome back roland! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 19, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 20, 2026

@rwestrel this pull request can not be integrated into lworld due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout emit_reference_load
git fetch https://git.openjdk.org/valhalla.git lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push

@openjdk openjdk Bot added the merge-conflict Pull request has merge conflict with target branch label May 20, 2026
@rwestrel rwestrel force-pushed the emit_reference_load branch from 4e7cdf7 to 6700b25 Compare May 20, 2026 13:00
@openjdk openjdk Bot removed the merge-conflict Pull request has merge conflict with target branch label May 20, 2026
assert(flat_nullfree_not_atomic_count_offset << LogBytesPerWord == real_flat_nullfree_not_atomic_count_offset, "poly counter math");
#endif

// Corner case: no profile table. Increment poly counter and exit.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the comment outdated? If not, is the implementation right?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That comment is outdated indeed

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 21, 2026

⚠️ @rwestrel This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@rwestrel rwestrel force-pushed the emit_reference_load branch from f924299 to 170c629 Compare June 1, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants