Emit reference load#2453
Conversation
|
👋 Welcome back roland! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@rwestrel this pull request can not be integrated into git checkout emit_reference_load
git fetch https://git.openjdk.org/valhalla.git lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push |
4e7cdf7 to
6700b25
Compare
| assert(flat_nullfree_not_atomic_count_offset << LogBytesPerWord == real_flat_nullfree_not_atomic_count_offset, "poly counter math"); | ||
| #endif | ||
|
|
||
| // Corner case: no profile table. Increment poly counter and exit. |
There was a problem hiding this comment.
Is the comment outdated? If not, is the implementation right?
There was a problem hiding this comment.
That comment is outdated indeed
|
|
f924299 to
170c629
Compare
XXX
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2453/head:pull/2453$ git checkout pull/2453Update a local copy of the PR:
$ git checkout pull/2453$ git pull https://git.openjdk.org/valhalla.git pull/2453/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2453View PR using the GUI difftool:
$ git pr show -t 2453Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2453.diff