Chore/sentry errors #238
Open
Chore/sentry errors #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we currently do not get any error logs besides the general error handler, that does not report to sentry because there is no error wrapping
|
|
pteich
requested changes
May 19, 2025
extracted a sctruct because there were too many params separated the actual check from the preparation reported only client errors to sentry
pteich
approved these changes
May 19, 2025
| tenantID, err := openmfpcontext.GetTenantFromContext(ctx) | ||
| if err != nil { | ||
| return nil, err | ||
| if !res.Allowed { |
There was a problem hiding this comment.
Are we sure res is always not nil if no error occured?
directive/authorized.go
Outdated
| log.Error().Err(err).Str("user", req.TupleKey.User).Msg("authorization check failed") | ||
| return nil, err | ||
| } | ||
| func (ac *authChecker) extractValuesToCheckFromRequest(ctx context.Context, entityParamName string, entityTypeParamName *string, entityType *string) (context.Context, bool, string, string, string, error) { |
There was a problem hiding this comment.
This would be one of the rare situations where named return values could be useful both for documentation and for preventing returning a lot of "" without knowing what it actually is and returning the (empty) variables instead.
There was a problem hiding this comment.
The name extractValue is a bit misleading as it does extract but also creates a new context?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we currently do not get any error logs besides the general error handler, that does not report to sentry because there is no error wrapping