Skip to content

Validate urlPath before execute, prevent null pointer exception #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Samnang-An wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Validate urlPath before execute, prevent null pointer exception #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ...ain/java/org/openmrs/module/referenceapplication/page/controller/LoginPageController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
*/
package org.openmrs.module.referenceapplication.page.controller;

import javax.validation.Validator;
import org.apache.commons.lang.StringUtils;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
Expand Down Expand Up @@ -162,9 +163,13 @@ private boolean isUrlWithinOpenmrs(PageRequest pageRequest, String redirectUrl)
try {
URL url = new URL(redirectUrl);
String urlPath = url.getFile();
String urlContextPath = urlPath.substring(1).contains("/") ? urlPath.substring(0, urlPath.indexOf('/', 1)) : urlPath;
if (StringUtils.equals(pageRequest.getRequest().getContextPath(), urlContextPath)) {
return true;
if(StringUtils.isNotEmpty(urlPath)) {
String urlContextPath =
urlPath.substring(1).contains("/") ? urlPath.substring(0, urlPath.indexOf('/', 1))
: urlPath;
if (StringUtils.equals(pageRequest.getRequest().getContextPath(), urlContextPath)) {
return true;
}
}
}
catch (MalformedURLException e) {
Expand Down