TRUNK-6203: Global properties access should be privileged #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkayiwa
reviewed
Jun 19, 2024
| .getGlobalProperty(ReferenceApplicationConstants.LOCATION_USER_PROPERTY_NAME); | ||
| String locationUserPropertyName; | ||
| try { | ||
| Context.addProxyPrivilege(PrivilegeConstants.GET_GLOBAL_PROPERTIES); |
Member
There was a problem hiding this comment.
Does this mean that line 382 below results into a NPE for Context.getAuthenticatedUser().getUserProperty()?
5 tasks
Member
|
@wikumChamith do you remember why we abandoned this pull request? |
Member
Author
@dkayiwa Sorry, I can’t quite remember why this was abandoned—most likely, we just forgot to merge it :) |
Member
|
@wikumChamith are you able to reproduce the problem that it was intended to solve? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After openmrs/openmrs-core#4601, users must possess the 'Get Global Properties' privilege to access global properties. This grants it as a proxy privilege so users can access essential pages, such as the login page.
Ticket: https://openmrs.atlassian.net/browse/TRUNK-6203