Skip to content

Conversation

@mozzy11
Copy link
Member

@mozzy11 mozzy11 commented Jan 20, 2019

https://issues.openmrs.org/browse/RA-429

added liquibase file that deletes duplicate concepts

import org.openmrs.Concept;
import org.openmrs.api.context.Context;

public class AdministrativeNotification {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this class got anything to do with the ticket?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well i was just trying to figure out , how i can display an administrative notification on the user UI .. but i failed to get exactly an example of how to use the org.openmrs.module.appframework.factory.AdministrativeNotificationProduce

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is it related to this ticket?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought that method can be used to check whether duplicate concepts exists , and then trigers the administration Notification requested by he ticket

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

though am not yet sure how to display an administration notification on the UI as done in the atlas module. i failed to gt any reference documentation on how to do it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ya samwel , acoording to the acceptance criteria ...
Upon upgrading an existing OpenMRS installation, if it has two TRUE or FALSE concepts, the administrator should be shown instructions about how to clean this up in their database.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

soi was trying out making a method that will trigger the amin notification

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but am soon pushing , i have modified that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi dan , let me close this PR, i have created a new one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please look at this #40

and openmrs/openmrs-module-referenceapplication#50

am closing this

@mozzy11 mozzy11 closed this Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants