Always add explicit type to the Predicate.isEqual method
#927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, the type can be inferred, but not always. To follow the “Do no harm” principle, it’s safer to always "cast" the `Predicate.isEqual` method explicitly. Before this commit, certain cases resulted in compilation errors (see the new test inlinedPredicatesEqualToWithStandardType, which reveals this problem).
It seems that the recipe NoGuavaMapsNewLinkedHashMap has never been added in `no-guava.yml`.
timtebeek
changed the title
Predicate.isEqual method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
After analysis, I discovered 2 new cases detailed in the commit message.
Checklist