Jongmassey/port icd10 scrape#3129
Open
Jongmassey wants to merge 2 commits into
Open
Conversation
4f5d517 to
ba46b96
Compare
Remove main methods Port from lxml to xml Rename for clarity
ba13092 to
c655aee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move icd browser scraper and claml converter code from bennettoxford/icd-browser-scraper into opencodelists for production scraping purposes.
The source project uses
lxmlfor XML wrangling, but closer inspection shows the base pythonxmlpackage will suffice and so this code is changed to use the latter as not to add another dependency.Both the scraping and conversion scripts were written with the expectation of the browser scraper project structure and to be called as standalone scripts from the CLI. They are changed here such that they have main entry functions that can be easily called from other scripts as part of the ICD-10 import process.