feat(server): add opt-in KVM access for Linux Docker sandboxes - #1677
Open
kernalix7 wants to merge 3 commits into
Open
feat(server): add opt-in KVM access for Linux Docker sandboxes#1677kernalix7 wants to merge 3 commits into
kernalix7 wants to merge 3 commits into
Conversation
kernalix7
requested review from
Generalwin,
Pangjiping,
hittyt,
jwx0925 and
ninan-nn
as code owners
August 30, 2026 09:50
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b1556d2de
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resourceLimits.kvm: "1"opt-in for generic Linux sandboxes on a local Docker runtime./dev/kvmwithlstatas character device10:232, map only/dev/kvm:/dev/kvm:rwinto the main container, and add only its non-root GID.Closes #1676
Testing
Validation performed:
git diff --check: cleanReal Docker/KVM E2E was not run because this environment has neither Docker nor
/dev/kvm. Kotlin lifecycle generation was not run because no JDK is installed; its generated build output is ignored and untracked. Python package build was not run because the local environment lacks the build backend, while generator/lint/type/tests passed.Breaking Changes
Checklist