Skip to content

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Oct 13, 2025

Description

  1. update some style panel accordions default to be closed
  2. change default legend position to bottom
  3. default to not show axis title for time/numeric axis if not specified

Issues Resolved

Screenshot

Testing the changes

Changelog

  • feat: update discover vis defaults

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 71.73913% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.46%. Comparing base (bc35949) to head (90406c0).

Files with missing lines Patch % Lines
...nents/visualizations/metric/metric_vis_options.tsx 40.00% 3 Missing and 3 partials ⚠️
...nts/visualizations/heatmap/heatmap_vis_options.tsx 33.33% 1 Missing and 1 partial ⚠️
...ponents/visualizations/visualization_container.tsx 50.00% 0 Missing and 2 partials ⚠️
...lic/components/visualizations/bar/to_expression.ts 50.00% 0 Missing and 1 partial ⚠️
...ponents/visualizations/gauge/gauge_vis_options.tsx 80.00% 1 Missing ⚠️
...nts/visualizations/scatter/scatter_vis_options.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10711   +/-   ##
=======================================
  Coverage   60.46%   60.46%           
=======================================
  Files        4483     4483           
  Lines      120056   120065    +9     
  Branches    19879    19891   +12     
=======================================
+ Hits        72595    72602    +7     
  Misses      42424    42424           
- Partials     5037     5039    +2     
Flag Coverage Δ
Linux_1 26.58% <ø> (ø)
Linux_2 38.82% <ø> (ø)
Linux_3 39.04% <ø> (+<0.01%) ⬆️
Linux_4 33.23% <71.73%> (+<0.01%) ⬆️
Windows_1 26.59% <ø> (ø)
Windows_2 38.79% <ø> (ø)
Windows_3 39.04% <ø> (-0.01%) ⬇️
Windows_4 33.23% <71.73%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ruanyl ruanyl changed the title [Explore Vis] update discover vis defaults [Explore vis] update discover vis defaults Oct 13, 2025
1. update some style panel accordions default to be closed
2. change default legend position to bottom
3. default to not show axis title for time/numeric axis if not specified

Signed-off-by: Yulong Ruan <[email protected]>
@ruanyl ruanyl force-pushed the update-vis-panel-default-state branch from cf4211a to 90406c0 Compare October 17, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant