Fix indexPattern link on Asset table #10721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joey Liu <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10721 +/- ##
==========================================
+ Coverage 60.29% 60.35% +0.05%
==========================================
Files 4460 4462 +2
Lines 119352 119490 +138
Branches 19711 19747 +36
==========================================
+ Hits 71968 72120 +152
+ Misses 42385 42372 -13
+ Partials 4999 4998 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Joey Liu <[email protected]>
Maosaic
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
ashwin-pc,
bandinib-amzn,
curq,
huyaboo,
joshuali925,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ruanyl,
sejli,
virajsanghvi,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
Maosaic
requested review from
TackAdam,
angle943,
d-buckner,
paulstn,
ps48,
raintygao,
ruchidh,
sumukhswamy and
wanglam
as code owners
|
Working for Trace/Log indexs Test.mov |
TackAdam
approved these changes
Oct 16, 2025
paulstn
approved these changes
Oct 16, 2025
| }); | ||
|
|
||
| // Forward indexPatterns management page to datasets management page | ||
| urlForwarding.forwardApp('indexPatterns', DM_APP_ID, (path) => { |
There was a problem hiding this comment.
Would we be removing the indexPatterns management page code at some point, if its being deprecated? Is it being deprecated?
There was a problem hiding this comment.
Eventaully yes, for now they are coexist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a problem causing indexPattern link on Asset table failed to load when dataset management plugin is enabled.
Saved object server side compute URL of
indexPatterntype as/indexPatterns/patterns/*which does not match with dataset management plugin route.https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/data/server/saved_objects/index_patterns.ts#L45-L56
This PR update dataset management plugin to register a redirection from
/indexPatternsroute to/datasetsThis PR also added unit test to cover some components introduced by #10714
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration