-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Ruchi/cancel query #10727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Ruchi/cancel query #10727
Conversation
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
…strategy.test.ts Signed-off-by: Ruchi Sharma <[email protected]>
Removed note about backend query cancellation handling. Signed-off-by: Ruchi Sharma <[email protected]>
Added check for inProgressQueryId before modifying request body. Signed-off-by: Ruchi Sharma <[email protected]>
Removed comments explaining the abortAllActiveQueries function. Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
2 similar comments
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
Signed-off-by: Ruchi Sharma <[email protected]>
Removed the abort signal handling tests from the ppl_search_interceptor test suite. Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10727 +/- ##
==========================================
- Coverage 60.34% 50.55% -9.79%
==========================================
Files 4462 3971 -491
Lines 119488 106911 -12577
Branches 19746 17152 -2594
==========================================
- Hits 72102 54049 -18053
- Misses 42383 49541 +7158
+ Partials 5003 3321 -1682
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Ruchi Sharma <[email protected]>
Remove commented-out contextProvider configuration Signed-off-by: Ruchi Sharma <[email protected]>
Refactor tests for QueryEditorTopRow to improve structure and readability. Update mocks and assertions for better clarity and maintainability. Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Increase delay for showing the cancel button from 100ms to 500ms. Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
There are some tests that are failing due to the changes, some related to snapshots. Could you fix the tests and run the linter? Typically, we have a precommit validation that runs that should run the linter on changed files. |
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Description
Summary
This PR implements a comprehensive cancel button feature for query execution across OpenSearch Dashboards, allowing users to cancel running
queries in both the standard QueryEditor and custom QueryExecutionButton scenarios.
The implementation provides a unified cancel button
experience that works consistently across different data source types (OpenSearch and S3).
What Changed
Core Features
Screenshot
Screen.Recording.2025-10-15.at.3.52.17.PM.mov
Changelog
Check List
yarn test:jest
yarn test:jest_integration