Skip to content

Conversation

jessrlew
Copy link
Contributor

@jessrlew jessrlew commented Oct 15, 2025

Description

Fixes a couple of bugs on the trace details page and trace flyout:

  1. The trace details page would make a duplicate PPL call to fetch spans => removed unnecessary dependency from hook
  2. The dataset would reload whenever the flyout opened => pass in a default dataset
  3. The flyout would select the wrong spanId due to the order of hooks => if the traceId has changed, wait to finish fetching all spans before updating the selected span
  4. The flyout wouldn't show a loading spinner when loading a new trace => update loading state to check if the traceId has changed

Issues Resolved

Screenshot

trace_flyout_loading.mov

Testing the changes

Changelog

  • fix: Trace details flyout loading

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.36%. Comparing base (fe5ae72) to head (ba36cc2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10728   +/-   ##
=======================================
  Coverage   60.36%   60.36%           
=======================================
  Files        4463     4463           
  Lines      119589   119593    +4     
  Branches    19771    19772    +1     
=======================================
+ Hits        72187    72191    +4     
- Misses      42392    42393    +1     
+ Partials     5010     5009    -1     
Flag Coverage Δ
Linux_1 26.58% <ø> (ø)
Linux_2 38.82% <ø> (ø)
Linux_3 38.89% <ø> (+<0.01%) ⬆️
Linux_4 33.07% <100.00%> (-0.01%) ⬇️
Windows_1 26.60% <ø> (ø)
Windows_2 38.79% <ø> (ø)
Windows_3 38.90% <ø> (+<0.01%) ⬆️
Windows_4 33.07% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jessrlew pushed a commit to jessrlew/OpenSearch-Dashboards that referenced this pull request Oct 15, 2025
@jessrlew jessrlew force-pushed the fix/trace_flyout_loading branch from 5bceff2 to 43899b3 Compare October 15, 2025 18:10
@TackAdam TackAdam added the OSD Changes being merged by the OSD team label Oct 15, 2025
@jessrlew jessrlew force-pushed the fix/trace_flyout_loading branch from a31eccf to ba36cc2 Compare October 15, 2025 23:13
Copy link
Collaborator

@TackAdam TackAdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@TackAdam TackAdam merged commit 2bea5d6 into opensearch-project:main Oct 16, 2025
101 of 105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OSD Changes being merged by the OSD team valued-contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants