-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Trace Details: Fix trace flyout loading #10728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trace Details: Fix trace flyout loading #10728
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10728 +/- ##
=======================================
Coverage 60.36% 60.36%
=======================================
Files 4463 4463
Lines 119589 119593 +4
Branches 19771 19772 +1
=======================================
+ Hits 72187 72191 +4
- Misses 42392 42393 +1
+ Partials 5010 5009 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5bceff2
to
43899b3
Compare
Signed-off-by: Jessica Lew <[email protected]>
a31eccf
to
ba36cc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Description
Fixes a couple of bugs on the trace details page and trace flyout:
Issues Resolved
Screenshot
trace_flyout_loading.mov
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration