-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add correlations tab to support linking Trace and Logs Datasets #10729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: ps48 <[email protected]>
Signed-off-by: ps48 <[email protected]>
Signed-off-by: ps48 <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10729 +/- ##
==========================================
+ Coverage 60.34% 60.41% +0.07%
==========================================
Files 4462 4468 +6
Lines 119495 119752 +257
Branches 19748 19800 +52
==========================================
+ Hits 72109 72349 +240
- Misses 42383 42392 +9
- Partials 5003 5011 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: ps48 <[email protected]>
Testing this change against the Traces workflow. Required update to the log fetching as the correlation is a different object structure in src/plugins/explore/public/application/pages/traces/trace_details/public/logs/correlation_service.ts Works great, nice change! Tested.mov |
)} | ||
|
||
{/* Show error callout only when there are missing mappings */} | ||
{hasErrors && missingMappings.length > 0 && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we show a generic unknown error in other cases where hasErrors is true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If hasErrors = true
, then at least one row found a matching entry in missing mappings with non-empty missingFields, which means missingMappings.length > 0
must be true
. hasErrors
is kept as a separate variable for react state update race conditions.
TL;DR generic unknown error cannot be caught with hasErrors it just checks for missing mappings.
Signed-off-by: ps48 <[email protected]>
Signed-off-by: ps48 <[email protected]>
Signed-off-by: ps48 <[email protected]>
Description
Add support for correlations tab for Datasets feature.
Issues Resolved
#10386
Screenshot / Testing the changes
correlations-feature.mov
Changelog
Check List
yarn test:jest
yarn test:jest_integration