Skip to content

Conversation

@kakshak07
Copy link
Contributor

@kakshak07 kakshak07 commented Oct 16, 2025

Description

Made tab persistent across different span selection and default fallback to Overview in case of tab not found

Issues Resolved

Made tab persistent across different span selection and default fallback to Overview in case of tab not found, even if you switch between span and timeline persistent of tabs is saved

Screenshot

Screen.Recording.2025-10-16.at.3.52.38.PM.mov

Testing the changes

Added testing for the same

Changelog

  • feat: Made tab persistent across different span selection

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Kakshak Pravin Porwal <[email protected]>
@github-actions
Copy link
Contributor

❌ Entry Too Long

Entry is 110 characters long, which is 10 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length.

@TackAdam TackAdam added the OSD Changes being merged by the OSD team label Oct 16, 2025
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.47%. Comparing base (e38fcaf) to head (b28710a).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10738   +/-   ##
=======================================
  Coverage   60.46%   60.47%           
=======================================
  Files        4481     4482    +1     
  Lines      120062   120078   +16     
  Branches    19884    19888    +4     
=======================================
+ Hits        72599    72619   +20     
+ Misses      42424    42422    -2     
+ Partials     5039     5037    -2     
Flag Coverage Δ
Linux_1 26.58% <ø> (ø)
Linux_2 38.82% <ø> (ø)
Linux_3 39.04% <ø> (ø)
Linux_4 33.24% <100.00%> (+0.01%) ⬆️
Windows_1 26.59% <ø> (ø)
Windows_2 38.79% <ø> (ø)
Windows_3 39.04% <ø> (ø)
Windows_4 33.24% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yanatha99
Copy link
Contributor

yanatha99 commented Oct 17, 2025

Not merging this in. Need to wait for filter feature change in Trace Details #10742 to merge in. I will then pull these changes locally to rebase and fix any conflicts before pushing.

@yanatha99
Copy link
Contributor

Some tests failing from mix of index pattern and data fetch errors due to 500s. Seems like they just flaked? Need a re-run to be 100% sure no problems with change.

@yanatha99
Copy link
Contributor

Just a reminder: DO NOT merge this PR. Merge #10745 instead.

@TackAdam TackAdam closed this Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OSD Changes being merged by the OSD team repeat-contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants