-
Notifications
You must be signed in to change notification settings - Fork 1.1k
made tab persistent #10738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
made tab persistent #10738
Conversation
Signed-off-by: Kakshak Pravin Porwal <[email protected]>
❌ Entry Too LongEntry is 110 characters long, which is 10 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10738 +/- ##
=======================================
Coverage 60.46% 60.47%
=======================================
Files 4481 4482 +1
Lines 120062 120078 +16
Branches 19884 19888 +4
=======================================
+ Hits 72599 72619 +20
+ Misses 42424 42422 -2
+ Partials 5039 5037 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Not merging this in. Need to wait for filter feature change in Trace Details #10742 to merge in. I will then pull these changes locally to rebase and fix any conflicts before pushing. |
|
Some tests failing from mix of index pattern and data fetch errors due to 500s. Seems like they just flaked? Need a re-run to be 100% sure no problems with change. |
|
Just a reminder: DO NOT merge this PR. Merge #10745 instead. |
Description
Made tab persistent across different span selection and default fallback to Overview in case of tab not found
Issues Resolved
Made tab persistent across different span selection and default fallback to Overview in case of tab not found, even if you switch between span and timeline persistent of tabs is saved
Screenshot
Screen.Recording.2025-10-16.at.3.52.38.PM.mov
Testing the changes
Added testing for the same
Changelog
Check List
yarn test:jestyarn test:jest_integration