-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix: Correctly show error message in DQL and PPL query editor #9589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Correctly show error message in DQL and PPL query editor #9589
Conversation
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9589 +/- ##
==========================================
- Coverage 61.85% 61.85% -0.01%
==========================================
Files 3802 3802
Lines 91982 91992 +10
Branches 14627 14632 +5
==========================================
+ Hits 56898 56904 +6
Misses 31407 31407
- Partials 3677 3681 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/plugins/discover/public/application/view_components/utils/use_search.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add some unit tests?
can you remove the code changes included in #9586 ? I have made some change on that PR, to avoid conflicts and keep thing clean, I think we should remove the duplicate change here. |
f888102
to
4524c06
Compare
32f340f
to
09e0849
Compare
added |
done |
abc9949
to
2549e8e
Compare
Test failed
|
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
Signed-off-by: Ruchi Sharma <[email protected]>
9106ec1
to
237038f
Compare
Description
This PR fix a bug that causing error message in query editor as message[object object] instead of the correct error message .
There are 2 major changes in this PR:
Correctly throw error from fetch result
Properly handle error message base on current error structure
Issues Resolved
Fix message [object object] issue in ppl editor
Screenshot
Before
After
Changelog
Check List
yarn test:jest
yarn test:jest_integration