Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Enable default throttling with thresholds based on task type for Cluster Manager in 3.0 #17685

Open
gargmanik13 opened this issue Mar 25, 2025 · 3 comments · May be fixed by #17711
Assignees
Labels
Cluster Manager enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0

Comments

@gargmanik13
Copy link

Is your feature request related to a problem? Please describe

Currently, by default Cluster Manager throttling is disabled for all tasks in ClusterManagerThrottle.

Describe the solution you'd like

We can enable throttling with some thresholds for each task type by default.

Related component

Cluster Manager

Describe alternatives you've considered

No response

Additional context

No response

@gargmanik13 gargmanik13 added enhancement Enhancement or improvement to existing feature or request untriaged labels Mar 25, 2025
@rajiv-kv rajiv-kv added the v3.0.0 Issues and PRs related to version 3.0.0 label Mar 25, 2025
@andrross
Copy link
Member

Thanks @gargmanik13! Linking #17170 for reference.

@rajiv-kv
Copy link
Contributor

[Triage - 1, 2, 3, 4]

Thanks @gargmanik13 for filing the issue. We discussed the following two options

  1. Enable with a default value (say 50) for all the task-type
  2. Enable with a default value based on specific task-type

Please evaluate these options.

We also discussed concern of throttling for critical recovery tasks such as node-join and node-left if we enable by default. However by design, the throttling is not enabled for default task type which means that only certain task-type executions are throttled. Please confirm the same as well.

@gargmanik13
Copy link
Author

gargmanik13 commented Apr 3, 2025

Thanks @rajiv-kv for the suggestions.

  • Proposing to use default value based on specific task-type, since certain tasks like - put_mapping with high frequency use might throttle.
  • Throttling will be enabled by default only for tasks which are registered in ClusterManagerTaskThrottler, critical recovery tasks are not registered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cluster Manager enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

3 participants