Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled default throttling for all tasks submitted to cluster manager #17711

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enabled default throttling for all tasks submitted to cluster manager #17711

wants to merge 1 commit into from
+114 −25

Conversation

gargmanik13
Copy link

@gargmanik13 gargmanik13 commented Mar 27, 2025 •
edited
Loading

Description

Enabled default throttling for all tasks submitted to cluster manager.

  • Added default threshold values based on task type in ClusterManagerThrottlingDefaults class
  • If default threshold value for a task type is not present in ClusterManagerThrottlingDefaults, then we will use 50 as default threshold

Related Issues

Resolves #17685

Check List

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added Cluster Manager enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0 labels Mar 27, 2025
@gargmanik13 gargmanik13 force-pushed the enable_default_throttling branch 2 times, most recently from e8571ca to 031e751 Compare March 27, 2025 14:05
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 031e751:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gargmanik13
Copy link
Author

Test Result (2 failures / -2)
org.opensearch.rest.ReactorNetty4StreamingStressIT.testCloseClientStreamingRequest
org.opensearch.rest.ReactorNetty4StreamingStressIT.classMethod

Flaky Test - #15840

@gargmanik13 gargmanik13 force-pushed the enable_default_throttling branch from 031e751 to 7aa3bc8 Compare March 27, 2025 16:40
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Mar 27, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 7aa3bc8:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 7aa3bc8: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gargmanik13 gargmanik13 force-pushed the enable_default_throttling branch from 7aa3bc8 to f7ca2c0 Compare March 28, 2025 05:15
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for f7ca2c0: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Mar 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.47%. Comparing base (8182bb0) to head (3306d3c).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #17711      +/-   ##
============================================
+ Coverage     72.29%   72.47%   +0.18%     
- Complexity    65900    66073     +173     
============================================
  Files          5350     5350              
  Lines        306185   306211      +26     
  Branches      44373    44376       +3     
============================================
+ Hits         221347   221923     +576     
+ Misses        66670    66136     -534     
+ Partials      18168    18152      -16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Mar 28, 2025
Open
@gargmanik13
Copy link
Author

❕ Gradle check result for f7ca2c0: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Test Result (1 failure / -34)
org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Flaky Test - #14289

@gargmanik13 gargmanik13 marked this pull request as ready for review March 28, 2025 07:12
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

❕ Gradle check result for 3306d3c: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@gargmanik13 gargmanik13 force-pushed the enable_default_throttling branch from 3306d3c to ec0e94f Compare April 3, 2025 09:35
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

❌ Gradle check result for ec0e94f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gargmanik13
Copy link
Author

❌ Gradle check result for ec0e94f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Test Result (2 failures / -1)
org.opensearch.repositories.s3.S3BlobContainerRetriesTests.classMethod
org.opensearch.repositories.s3.S3BlobContainerRetriesTests.classMethod

Flaky test:
#17551

rajiv-kv
rajiv-kv reviewed Apr 9, 2025
View reviewed changes
server/src/main/java/org/opensearch/cluster/service/ClusterManagerThrottlingDefaults.java
Comment on lines +22 to +23
DEFAULT_THRESHOLDS.put(ClusterManagerTaskKeys.CREATE_INDEX_KEY, 50);
DEFAULT_THRESHOLDS.put(ClusterManagerTaskKeys.UPDATE_SETTINGS_KEY, 50);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the ones with value=50, should we skip populating the map DEFAULT_THRESHOLDS ?

server/src/main/java/org/opensearch/cluster/service/ClusterManagerThrottlingDefaults.java
Comment on lines +42 to +45
DEFAULT_THRESHOLDS.put(ClusterManagerTaskKeys.DELETE_SEARCH_PIPELINE_KEY, 200);
DEFAULT_THRESHOLDS.put(ClusterManagerTaskKeys.CREATE_PERSISTENT_TASK_KEY, 200);
DEFAULT_THRESHOLDS.put(ClusterManagerTaskKeys.FINISH_PERSISTENT_TASK_KEY, 200);
DEFAULT_THRESHOLDS.put(ClusterManagerTaskKeys.REMOVE_PERSISTENT_TASK_KEY, 200);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we require 200 ? Can this be 50 as well given that the calls are task related and is expected to be low.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajiv-kv rajiv-kv rajiv-kv left review comments

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@bugmakerrrrrr bugmakerrrrrr Awaiting requested review from bugmakerrrrrr bugmakerrrrrr is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Cluster Manager enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0
Projects
Cluster Manager Project Board
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Enable default throttling with thresholds based on task type for Cluster Manager in 3.0
2 participants
@gargmanik13 @rajiv-kv